Skip to content

Conversation

@gitlimes
Copy link
Member

@gitlimes gitlimes commented Sep 1, 2025

Implements the Mii Editor UI, slowly inching towards #386.

Changes:

  • Implement the mii editor UI
  • Backend logic (not yet at time of writing)

@gitlimes gitlimes changed the title Nuxt refactor miieditor Mii Editor Nuxt refactor Sep 1, 2025
@gitlimes
Copy link
Member Author

gitlimes commented Sep 1, 2025

Hmm, I just tried actually building this, not just running the dev server, and it looks like the mii-js library isn't being bundled correctly? will have to look into this, but in the meantime @mrjvs (and anyone else), any idea why that might be happening?

@mrjvs
Copy link
Contributor

mrjvs commented Sep 2, 2025

@gitlimes The issue is that mii-js doesn't support ESM, and nuxt v3 is fully ESM. We can't properly bypass it either because of the polyfills needed.

I'll make an update to the lib to make it compatible with browser and ESM

@gitlimes
Copy link
Member Author

gitlimes commented Sep 2, 2025

@gitlimes The issue is that mii-js doesn't support ESM, and nuxt v3 is fully ESM. We can't properly bypass it either because of the polyfills needed.

I'll make an update to the lib to make it compatible with browser and ESM

oh, i see. (in my defense i hadn't really looked into it lol). Thanks!

weird behavior for it to work in dev and not in prod tho, that sounds like it would lead to many issues like these

@mrjvs
Copy link
Contributor

mrjvs commented Sep 2, 2025

I have an update to the library prepared, just needs to be reviewed: PretendoNetwork/mii-js#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants