feat: Update to matchmaking rewrite #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes partial support for communities. They can be created and you can join one, but no statistics will be shown since legacy Ranking isn't implemented. Partially solves #3
|
Any updates on merging this? Either way, I've been waiting for months for this to be made, tysm for writing it! |
|
I think this shouldn't be merged right now, since while the code is good, it exposes some underlying bugs in nex-go that result in widespread connection issues (we've been seeing this on Wii U). We had to revert it in Splatoon for this reason: PretendoNetwork/splatoon#12 (comment) This PR should be mergeable once that underlying nex-go issue is identified and fixed. |
|
|
|
Still have that issue? If so, couldn't just the communities be implemented? As far as I can tell, just the changes in |
This also includes the ability to create and join communities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PretendoNetwork/nex-protocols-common-go#45
Partially solves #3
Changes:
Also includes partial support for communities. They can be created and you can join one, but no statistics will be shown since legacy Ranking isn't implemented.