Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id_product in customer_message for v9 #1172

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

boherm
Copy link
Member

@boherm boherm commented Feb 19, 2025

Questions Answers
Description? Add id_product in customer_message table for v9.
Related to PrestaShop/PrestaShop#37861
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? ~
Sponsor company PrestaShop SA
How to test? ~

@boherm boherm force-pushed the add-id-product-in-customer-message branch 2 times, most recently from b55268e to 84a0a49 Compare February 19, 2025 08:35
@PrestaShop PrestaShop deleted a comment from sonarqubecloud bot Feb 19, 2025
@boherm
Copy link
Member Author

boherm commented Feb 19, 2025

Maybe, it's better to use add_column function 🤔 Let me know if I need to improve this PR!

@Quetzacoalt91
Copy link
Member

Maybe, it's better to use add_column function 🤔 Let me know if I need to improve this PR!

Yes, we have a helper method available for this purpose, able to update the column instead when it already exists. Can you please update your PR to use it? 🙏

@boherm boherm force-pushed the add-id-product-in-customer-message branch from 84a0a49 to 427c335 Compare February 19, 2025 10:07
@boherm
Copy link
Member Author

boherm commented Feb 19, 2025

@Quetzacoalt91, It's done!

@boherm boherm force-pushed the add-id-product-in-customer-message branch from 427c335 to 672275f Compare February 19, 2025 10:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Feb 19, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.0.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants