Disables run tracer with PREFECT_CLOUD_ENABLE_ORCHESTRATION_TELEMETRY
#17417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-automatic-opentelemetry
CodSpeed Performance ReportMerging #17417 will not alter performanceComparing Summary
|
jeanluciano
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
…opentelemetry' of https://github.com/PrefectHQ/prefect into jean/eng-1533-allow-user-to-disable-prefects-automatic-opentelemetry
zzstoatzz
approved these changes
Mar 7, 2025
desertaxle
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
LGTM! I left a couple of suggestions based on @zzstoatzz's comment
|
|
||
| async def async_start_span( | ||
| self, | ||
| run: FlowOrTaskRun, | ||
| client: PrefectClient, | ||
| parameters: dict[str, Any] | None = None, | ||
| ) -> Span: | ||
| ) -> Optional[Span]: |
There was a problem hiding this comment.
Suggested change
| ) -> Optional[Span]: | |
| ) -> Span | None: |
| @@ -73,7 +78,10 @@ def start_span( | |||
| run: FlowOrTaskRun, | |||
| client: SyncPrefectClient, | |||
| parameters: dict[str, Any] | None = None, | |||
| ) -> Span: | |||
| ) -> Optional[Span]: | |||
There was a problem hiding this comment.
Suggested change
| ) -> Optional[Span]: | |
| ) -> Span | None: |
zzstoatzz
reviewed
Mar 7, 2025
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import time | |||
| from dataclasses import dataclass, field | |||
| from typing import TYPE_CHECKING, Any, Union | |||
| from typing import TYPE_CHECKING, Any, Optional, Union | |||
There was a problem hiding this comment.
Suggested change
| from typing import TYPE_CHECKING, Any, Optional, Union | |
| from typing import TYPE_CHECKING, Any, Union |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the creation of spans when
PREFECT_CLOUD_ENABLE_ORCHESTRATION_TELEMETRYis on. This fixes issue with users importing our run telemetry with their own OTEL setup.closes #17190
Checklist
<link to issue>"mint.json.__