-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix authenticate bug and add unverified context #13428
Open
sm-ghavami
wants to merge
13
commits into
PrefectHQ:main
Choose a base branch
from
sm-ghavami:fix-authenticate-bug-and-add-unverified-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix authenticate bug and add unverified context #13428
sm-ghavami
wants to merge
13
commits into
PrefectHQ:main
from
sm-ghavami:fix-authenticate-bug-and-add-unverified-context
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new configuration parameter "verify", which determines whether an unverified SSL context should be used. By default, this parameter is set to True.
Purpose
When using custom certificates for the email server, email functionality may fail due to certificate verification issues. To address this, the new "verify" parameter allows users to initialize an unverified SSL context, facilitating successful email transmission in such cases.
Bug Fix
Additionally, this PR fixes a bug related to the handling of insecure email servers, ensuring we will authenticate in the case of having username and password.
Related PRs and issues in prefect_email repository
PR 81
Issue 13089
PR 70
Issue 13091
Example
Checklist
<link to issue>
"maintenance
,fix
,feature
,enhancement
,docs
.For documentation changes:
netlify.toml
for files that are removed or renamed.For new functions or classes in the Python SDK:
mkdocs.yml
navigation.