Use main landmark for page content#181
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nwalters512
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap the routed page content in
src/pages/_app.tsxwith a semantic<main>element while leaving the shared header and footer outside of it.This makes the deployed legal pages work better as canonical document sources for tools like Pandoc. Pandoc imports the
<main>content as the document body, so runningpandoc https://www.prairielearn.com/legal/terms -f html -o terms.docxno longer includes the site navigation text before the Terms of Service content.AI assistance: majority of implementation and validation.
Testing
pnpm lintpnpm buildpnpm start -p 30281and verifiedcurl -s http://localhost:30281/legal/terms | pandoc -f html -t plainstarts atTerms of ServicewithoutFree sign up,Login, or navigation text./tmp/terms-after.docxwithpandoc http://localhost:30281/legal/terms -f html -o /tmp/terms-after.docxand verified the DOCX text starts atTerms of Service.The first build attempt failed because the
PrairieLearnsubmodule was uninitialized in this worktree. Aftergit submodule update --init PrairieLearn, the build passed.