-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for code updation #177
Open
manavrmoorthy
wants to merge
5
commits into
PracticalDL:master
Choose a base branch
from
manavrmoorthy:manavrmoorthy/update-code
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Pull request for code updation #177
manavrmoorthy
wants to merge
5
commits into
PracticalDL:master
from
manavrmoorthy:manavrmoorthy/update-code
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… currently) - tensorflow gpu removed: https://github.com/tensorflow/tensorflow/releases/tag/v2.12.0 - upgrading tf-explain to 0.3.1 - and explainer.explain arguments ordering has changed, so made that generic - formatted the code
…d any data from kaggle and start training models - fit_generator -> fit function, and predict_generator -> predict function since they now support generator objects and the former functions are going to get deprecated soon - the gcloud sessions are not using the same runtime (so we need to re-download data) - using the same strategies to download through kaggle CLI in both notebooks 1 and 2 - deleted deprecated files - formatted the code
- removing deprecated files - the gcloud sessions are not using the same runtime (so we need to re-download data) so writing outputs to gdrive to make sure things are running and outputs are accessible for subsequent notebooks in colab - renaming 4/1 notebook - since it had underscores instead of hyphens, the colab link in the notebook was not working - xception added to imports for notebook 1, since it is part of the model_maker - PracticalDL#163 - fixed - PracticalDL#164 - fixed - PracticalDL#169 - fixed - metric='angular' added for annoy as default arg will be removed in subsequent releases - removing a duplicate PCA + Annoy section - PracticalDL#170 - fixed - time is a negligible factor here, and we do not need it in the plots (since we are using optimised accuracy calculation using numpy from issue 170) - hence, modifying the plots - removing matplotlib.style.use('seaborn') since it is deprecated - the final fine-tuning notebook uses Caltech256 features (as per the book), which do not exist, since fine-tuning was done on Caltech101 - hence, renaming those files to caltech101. Can we retain caltech101 to test? - PracticalDL#167 - fixed, if the above is okay - formatted the code chapter 5: - write_grads and batch_size params have been removed from callback, or will be removed in subsequent releases - PracticalDL#174 - not able to replicate this issue - added a pointer to the notebook that suggests that for tensorboard to work without a 403 Forbidden error on Colab, cookies need to be allowed (I faced this issue) - notebook 3 in chapter 5 is the exact same as notebook 2 in chapter 2 - replaced the file directly - the autokeras notebook in Colab is named autokeras-error.ipynb - where can we change this to autokeras.ipynb? - fixing accuracy score calculation in the autokeras notebook - formatted the code chapter 6: - including the download_sample_image function - formatted the code
- including the download_sample_image function - formatted the code chapter 7: - no changes chapter 8: - formatted the code - no bugs/issues reported - did not include colab support, as it was initially not present - these scripts are mainly to be configured to invoke API calls by using customized API keys
- formatted the code - tested the flask scripts, they work fine locally - CustomObjectScope - import resolved (Keras has updated documentation in v2) - PracticalDL#175 - fixed, updated the code to export models to pb format - https://saturncloud.io/blog/how-to-export-keras-h5-to-tensorflow-pb-a-comprehensive-guide/
meherkasam
reviewed
Jan 16, 2024
superimposed_img.save(output_path) | ||
print("SAVED") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line
meherkasam
reviewed
Jan 16, 2024
output_path = output_dir + "/result-" + str(counter).zfill(4) + '.jpg' | ||
output_path = output_dir + "/result-" + str(counter).zfill(4) + ".jpg" | ||
print(output_path) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The summary of changes included are as follows:
chapter 2:
https://github.com/tensorflow/tensorflow/releases/tag/v2.12.0
#173 - don't know the seriousness of this issue, skipping it for now. i am getting comparable times for training both models when i tried it, and there is nothing that specifically is needed to be changed in the code here for this
chapter 3:
chapter 4:
chapter 5:
chapter 6:
chapter 7: no code to update
NOTE - will edit this, as I add more changes.