Fix issue 163 and 164 in 1_feature_extraction.ipynb #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 changes in this notebook to fix #163 #164
Quoting paths to prevent zsh shells erroring with
zsh:1: no matches found: https://drive.google.com/uc?id=137RyRjvTBkBiIfeYBNZBtViDHQ6_Ewsp
because it treats ? as glob character.Convert
cat.jpg
that assumes user is running on colab intoIMG_PATH
that works on both colab and localMake generator produce 68 * 128 instead of 68 * 32 images
@sidgan
There are a few difficulties in me making PR on notebook files.
No local GPU
Later notebooks depend on data from previous notebooks. I have no GPU locally to produce those data. If I use colab for GPU, I have to add drive mounting code that messes up the notebook with extra cells. Current workflow is I generate necessary assets on colab then paste the changes individually from colab notebook to local notebook before commit. This means I never ran the local notebook top down, so there may be errors still.
Cell output management
It seems some cells have instructive output and some outputs are purposely deleted. It's best for the authors to run through the notebook again and decide what to show on the github version. I don't want to show my own filepaths in the output too.
Diffing notebooks
I tried ReviewNB but it gave a single chunk of red followed by a chunk of green because somehow it thinks the entire notebook changed. I eventually used nbdime locally, but if you know how I can use ReviewNB correctly, or any better way to communicate please advise.
Unaddressed issues
Outputs are still wrong
At this cell i think it should show (68, 'num epochs') because ceil(8677/128) = 68 not 67. It looks like someone ran it without ceil first then added the ceil code without running again so the output was stale, which is another reason I hope authors can run the notebook and give a final check on outputs.
Python2 in metadata
From json version of the ipynb we can see it is using python 2. The notebooks also open by default on python 2 in colab.
Changing it to python 3 may prevent frustration in users trying to debug a common issue, where syntax errors happen because python 2's print expected print 'hi' but the user think they're using python 3 and codes print('hi')