Make Settings type detection more robust#1967
Merged
andyleejordan merged 2 commits intoPowerShell:mainfrom Feb 20, 2025
Merged
Conversation
Contributor
Author
|
Related to #807 but that particular scenario was being covered. |
bergmeister
approved these changes
Feb 17, 2025
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
Thanks and sorry for late review. Kicked off CI and pending that all good.
591c051 to
16f6601
Compare
andyleejordan
requested changes
Feb 20, 2025
andyleejordan
approved these changes
Feb 20, 2025
Member
andyleejordan
left a comment
There was a problem hiding this comment.
Hopefully the tests still pass because I didn't test that myself!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
It was unable to parse settings hashtable, when that hashtable has been wrapped as a PSObject. This started happening in PS 7.2, I was using
Import-PowerShellDataFileto read some settings before passing them on toInvoke-ScriptAnalyzer.There was some code to handle wrapped strings, might as well do that with all parameter types.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.