Conversation
There was a problem hiding this comment.
Pull request overview
Adds schema sources for adapted resource manifests to the repository’s schema set, and wires the new manifest schema into the schema bundling configuration (to support publishing bundled/enhanced variants alongside existing resource/extension schemas).
Changes:
- Added
schemas/src/adaptedresource/manifest.yamldescribing the adapted resource manifest shape and authoring helpers. - Added
schemas/src/adaptedresource/manifest.schema.yamldefining the embedded instance schema shape for adapted resources. - Updated
schemas/schemas.config.yamlto generate bundled (Json+JsonVSCode) outputs for the adapted resource manifest schema.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| schemas/src/adaptedresource/manifest.yaml | New adapted resource manifest schema (incl. docs/snippets and $schema URI set). |
| schemas/src/adaptedresource/manifest.schema.yaml | New schema describing the embedded instance-schema object used by adapted resources. |
| schemas/schemas.config.yaml | Adds bundling config entry for adapted resource manifest schema outputs. |
| # Adapted resource manifest bundle | ||
| - ConfigFilePath: adaptedresource/manifest.json | ||
| Name: manifest | ||
| OutputDirectory: bundled/adaptedresource | ||
| OutputFormat: ['Json', 'JsonVSCode'] | ||
|
|
There was a problem hiding this comment.
This adds a bundle for adaptedresource/manifest.json, but schemas/build.ps1’s schema registry is built only from config/metadata/definitions/extension/outputs/resource directories. Without adding the adaptedresource directory there, bundling won’t inline refs to /.../adaptedresource/* and the post-processing step that strips VS Code-only keywords also won’t run on the adaptedresource schemas.
| # Adapted resource manifest bundle | |
| - ConfigFilePath: adaptedresource/manifest.json | |
| Name: manifest | |
| OutputDirectory: bundled/adaptedresource | |
| OutputFormat: ['Json', 'JsonVSCode'] |
There was a problem hiding this comment.
@michaeltlombardi - do you know by heart if this is a valid comment?
8b8e7bb to
e696f1b
Compare
PR Summary
This pull request adds the adapted resource schema files. I can remember from #1083 that it wasn't required to generate the
.jsonfiles.PR Context
Partially fixes #1460.