Skip to content

Add adapted resource schema files#1461

Open
Gijsreyn wants to merge 2 commits intoPowerShell:mainfrom
Gijsreyn:gh-1460/main/add-adaptedresource-schema
Open

Add adapted resource schema files#1461
Gijsreyn wants to merge 2 commits intoPowerShell:mainfrom
Gijsreyn:gh-1460/main/add-adaptedresource-schema

Conversation

@Gijsreyn
Copy link
Copy Markdown
Collaborator

@Gijsreyn Gijsreyn commented Apr 3, 2026

PR Summary

This pull request adds the adapted resource schema files. I can remember from #1083 that it wasn't required to generate the .json files.

PR Context

Partially fixes #1460.

Copilot AI review requested due to automatic review settings April 3, 2026 06:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds schema sources for adapted resource manifests to the repository’s schema set, and wires the new manifest schema into the schema bundling configuration (to support publishing bundled/enhanced variants alongside existing resource/extension schemas).

Changes:

  • Added schemas/src/adaptedresource/manifest.yaml describing the adapted resource manifest shape and authoring helpers.
  • Added schemas/src/adaptedresource/manifest.schema.yaml defining the embedded instance schema shape for adapted resources.
  • Updated schemas/schemas.config.yaml to generate bundled (Json + JsonVSCode) outputs for the adapted resource manifest schema.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
schemas/src/adaptedresource/manifest.yaml New adapted resource manifest schema (incl. docs/snippets and $schema URI set).
schemas/src/adaptedresource/manifest.schema.yaml New schema describing the embedded instance-schema object used by adapted resources.
schemas/schemas.config.yaml Adds bundling config entry for adapted resource manifest schema outputs.

Comment on lines +19 to +24
# Adapted resource manifest bundle
- ConfigFilePath: adaptedresource/manifest.json
Name: manifest
OutputDirectory: bundled/adaptedresource
OutputFormat: ['Json', 'JsonVSCode']

Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a bundle for adaptedresource/manifest.json, but schemas/build.ps1’s schema registry is built only from config/metadata/definitions/extension/outputs/resource directories. Without adding the adaptedresource directory there, bundling won’t inline refs to /.../adaptedresource/* and the post-processing step that strips VS Code-only keywords also won’t run on the adaptedresource schemas.

Suggested change
# Adapted resource manifest bundle
- ConfigFilePath: adaptedresource/manifest.json
Name: manifest
OutputDirectory: bundled/adaptedresource
OutputFormat: ['Json', 'JsonVSCode']

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeltlombardi - do you know by heart if this is a valid comment?

@Gijsreyn Gijsreyn force-pushed the gh-1460/main/add-adaptedresource-schema branch from 8b8e7bb to e696f1b Compare April 3, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapted Resource Manifest Schema

2 participants