-
Notifications
You must be signed in to change notification settings - Fork 52
Fix Ollama model and preset command help text formatting #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: StevenBucher98 <[email protected]>
…t commands Co-authored-by: StevenBucher98 <[email protected]>
@Copilot please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@daxian-dbw I'd need your expertise to determine if this is even close to right or not but wanted to try out the Copilot creation of PRs 😄 |
It did exactly what it said - removed tab completions for |
Summary
This PR fixes the issue where
/model
and/preset
command help text displayed all available models/presets in an unreadable single line format, making the output cluttered when multiple options are available.Problem
When users ran
/model
or/preset
commands without arguments, the help text would show all available models/presets concatenated on a single line:This became unreadable with multiple models/presets installed.
Solution
Removed the
AddCompletions()
calls from command arguments that were causing completion values to appear in help text. Users can still access properly formatted model/preset lists using:/model list
- shows all available models in a clean table format/preset list
- shows all available presets in a clean table formatChanges Made
.AddCompletions()
calls fromModelCommand
andPresetCommand
argumentsModelNameCompleter
method (15 lines) as it was no longer referencedPresetNameCompleter
method since it's still used for error message functionalityAfter the Fix
Help text is now clean and readable:
Impact
/model
and/preset
commands/model list
,/preset list
,/model use
,/preset use
)Total changes: 4 lines added, 19 lines removed - minimal and surgical fix.
Fixes #376.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
7tjvsblobprodcus341.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)c78vsblobprodcus322.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)d0svsblobprodcus381.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)h6tvsblobprodcus346.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)dotnet restore agents/AIShell.Ollama.Agent/AIShell.Ollama.Agent.csproj
(dns block)jd4vsblobprodcus366.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)l49vsblobprodcus358.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)u3hvsblobprodcus371.vsblob.vsassets.io
dotnet restore agents/AIShell.Ollama.Agent/AIShell.Ollama.Agent.csproj
(dns block)uy6vsblobprodcus34.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)vb4vsblobprodcus33.vsblob.vsassets.io
dotnet build AIShell.Abstraction/AIShell.Abstraction.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.