Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step-up transformer tap changer support: linear search control logic #893

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

control logic

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Feb 12, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this Feb 12, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title Feature/tap changer control logic linear search Step-up transformer tap changer support: linear search control logic Feb 12, 2025
Jerry-Jinfeng-Guo and others added 19 commits February 12, 2025 17:32
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
Signed-off-by: Jerry Guo <[email protected]>
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
…to feature/tap-changer-control-logic-linear-search
…eature/tap-changer-control-logic-binary-search
Signed-off-by: Jerry Guo <[email protected]>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo marked this pull request as ready for review February 13, 2025 21:22
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clear and readable PR. No comments 👍

Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…ol-logic-binary-search

Step-up transformer tap changer support: binary search control logic
@Jerry-Jinfeng-Guo
Copy link
Contributor Author

Jerry-Jinfeng-Guo commented Feb 21, 2025

Merging this PR to base PR /pull/892

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo merged commit ff6abe3 into feature/tap-changer-unit-test-for-new-control-logic Feb 21, 2025
24 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/tap-changer-control-logic-linear-search branch February 21, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants