Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / add unique regulators condition to data validator #829

Conversation

nitbharambe
Copy link
Member

No description provided.

@nitbharambe nitbharambe changed the base branch from main to feature/step-up-transformer-tap-changer-support November 11, 2024 14:36
Signed-off-by: Nitish Bharambe <[email protected]>
@nitbharambe nitbharambe marked this pull request as ready for review November 11, 2024 15:39
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, don't we also have to do some check on the core? EDIT: They exist:

// Make sure that each regulated object has at most one regulator
const std::unordered_set<Idx2D, Idx2DHash> unique_regulated_objects(regulated_objects.begin(),
regulated_objects.end());
if (unique_regulated_objects.size() != regulated_objects.size()) {
// There are duplicates
throw DuplicativelyRegulatedObject{};
}

@TonyXiang8787 TonyXiang8787 merged commit d7f9b46 into feature/step-up-transformer-tap-changer-support Nov 13, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/regulator-unique-validation branch November 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants