-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / add unique regulators condition to data validator #829
Feature / add unique regulators condition to data validator #829
Conversation
Signed-off-by: Martijn Govers <[email protected]>
…check [Feature] add check-blocking-labels github action
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, however, don't we also have to do some check on the core? EDIT: They exist:
power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp
Lines 171 to 177 in eeb5749
// Make sure that each regulated object has at most one regulator | |
const std::unordered_set<Idx2D, Idx2DHash> unique_regulated_objects(regulated_objects.begin(), | |
regulated_objects.end()); | |
if (unique_regulated_objects.size() != regulated_objects.size()) { | |
// There are duplicates | |
throw DuplicativelyRegulatedObject{}; | |
} |
…eature/regulator-unique-validation
|
d7f9b46
into
feature/step-up-transformer-tap-changer-support
No description provided.