Merge pull request #286 from PowerGridModel/fix-sonar

Fix sonar
PowerGridModel · Jan 8, 2025 · 906969e · 906969e
2 parents 8e420fd + faa51a6
commit 906969e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/build-test-and-sonar.yml b/.github/workflows/build-test-and-sonar.yml
@@ -96,7 +96,7 @@ jobs:
 
       - name: SonarCloud Scan
         if: ${{ (github.event_name == 'push') || (github.event.pull_request.head.repo.owner.login == 'PowerGridModel') }}
-        uses: SonarSource/sonarcloud-github-action@master
+        uses: SonarSource/sonarqube-scan-action@master
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

diff --git a/src/power_grid_model_io/functions/filters.py b/src/power_grid_model_io/functions/filters.py
@@ -31,7 +31,8 @@ def exclude_value(row: pd.Series, col: str, value: Union[float, str]) -> bool:
     if col not in row:
         raise ValueError(f"The column: '{col}' cannot be found for the filter")
     result = row[col] != value
-    if isinstance(result, pd.Series):
+    # Sonar cloud false positive (S2583): result can be a pd.Series of bool
+    if isinstance(result, pd.Series):  # NOSONAR
         return result.item()
     return result