rec: add feature to read TLS key info from an encrypted PKCS12 (pfx) file for the embedded web server#16855
Merged
omoerbeek merged 10 commits intoPowerDNS:masterfrom Feb 12, 2026
Merged
Conversation
miodvallat
reviewed
Feb 11, 2026
Pull Request Test Coverage Report for Build 21941309983Details
💛 - Coveralls |
8 tasks
miodvallat
reviewed
Feb 11, 2026
Contributor
miodvallat
left a comment
There was a problem hiding this comment.
Looking good but I am too rustic to know about rust.
…12 file Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Also add test infra to test for rec features Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
a71dc3c to
963cbac
Compare
Member
Author
|
Var renamed and rebased to pick up the new Rust compiler |
rgacogne
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This feature depends on the
timecrate, which in itself depends on modern (>= 1.88) rust build environment.Rather than pinning the
timecrate to an old version, add the infra to check thecargo/rustcversion used, so we can enable the feature if it is OK. Use a feature check in the tests to see if we must skip the test or not.You'll note that with our current CI build, the test is skipped as the feature is not enabled. I have a PR brewing to update the cargeo/rustc version used in CI. After that the feature and test wil be enabled.
Checklist
I have: