Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua up checks: finer control #14996

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This PR introduces two new options to the if*up Lua functions:

  • interval, if provided, overrides the global lua-health-checks-interval value for this particular test.
  • minimumFailures, if provided, is the number of unsuccessful checks in a row required to mark the address as down. The default is 1, which matches the current behaviour of marking an address as down at the first unsuccessful check.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12513391980

Details

  • 0 of 39 (0.0%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.001%) to 64.807%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/lua-record.cc 0 39 0.0%
Files with Coverage Reduction New Missed Lines %
pdns/lua-record.cc 1 0.2%
pdns/packethandler.cc 1 72.44%
pdns/recursordist/syncres.cc 1 80.16%
pdns/validate.cc 1 68.19%
pdns/pollmplexer.cc 1 83.66%
pdns/recursordist/recursor_cache.cc 1 84.2%
pdns/remote_logger.cc 3 54.26%
pdns/dnsrecords.cc 3 80.33%
pdns/recursordist/rec-tcp.cc 4 65.63%
pdns/dnsdistdist/dnsdist-carbon.cc 6 63.2%
Totals Coverage Status
Change from base Build 12496898214: 0.001%
Covered Lines: 126120
Relevant Lines: 163793

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants