Rework the QType class
#14410
Open
Rework the QType class
#14410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9774716334Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return "TYPE" + std::to_string(qtype); | ||
| } | ||
|
|
||
| static map<uint16_t, const string> swapElements(const map<const string, uint16_t>& names) |
Check notice
Code scanning / CodeQL
Unused static function Note
This adds QType::fromString() which does error checking and throws exceptions when invalid input is provided. Cleans up the anti-pattern that was previously there where you could only construct a QType object from a string by assigning to a dummy one. Also removes access to internals like chartocode which was being used all around in place of that anti-pattern.
Pull Request Test Coverage Report for Build 9776050440Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9792228263Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This adds
QType::fromString()which does error checking and throws exceptions when invalid input is provided.Cleans up the anti-pattern that was previously there where you could only construct a
QTypeobject from a string by assigning to a dummy one. Also removes access to internals likechartocodewhich was being used all around in place of that anti-pattern.I haven't tried to build dnsdist and the recursor with this change and I'll wait until tomorrow for the CI to give me feedback.
Checklist
I have: