Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: fix a crash and some cleanup in the auth-catalogzone.cc #14057

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mind04
Copy link
Contributor

@mind04 mind04 commented Apr 10, 2024

Short description

An incomplete SOA record like ns.example.com mail.example.com 1 in a producer zone resulted in termination of the communicator thread.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@coveralls
Copy link

coveralls commented Apr 10, 2024

Pull Request Test Coverage Report for Build 9418798096

Details

  • 23 of 50 (46.0%) changed or added relevant lines in 4 files are covered.
  • 45 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.002%) to 64.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/backends/gsql/gsqlbackend.cc 1 5 20.0%
modules/lmdbbackend/lmdbbackend.cc 0 5 0.0%
pdns/auth-catalogzone.cc 22 31 70.97%
pdns/auth-primarycommunicator.cc 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
modules/lmdbbackend/lmdbbackend.hh 1 90.0%
pdns/backends/gsql/gsqlbackend.cc 1 81.88%
pdns/recursordist/sortlist.cc 2 72.94%
pdns/recursordist/aggressive_nsec.cc 2 66.17%
pdns/misc.cc 2 63.35%
pdns/recursordist/test-syncres_cc2.cc 3 88.91%
pdns/dnsdistdist/dnsdist-carbon.cc 3 61.82%
modules/lmdbbackend/lmdbbackend.cc 3 73.5%
pdns/recursordist/rec-main.cc 3 61.68%
modules/gpgsqlbackend/spgsql.cc 3 67.7%
Totals Coverage Status
Change from base Build 9416932620: 0.002%
Covered Lines: 124373
Relevant Lines: 161708

💛 - Coveralls

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question; will do a full review later

modules/lmdbbackend/lmdbbackend.cc Show resolved Hide resolved
@Habbie Habbie added this to the auth-5 milestone Apr 11, 2024
Habbie added a commit that referenced this pull request May 14, 2024
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup :) I left a few comments. Also, clang-tidy is unhappy about your short ci and di variable names (you can see this in the Files view or https://github.com/PowerDNS/pdns/actions/runs/8660761587)

docs/lua-records/index.rst Outdated Show resolved Hide resolved
pdns/auth-catalogzone.cc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants