clang-analyzer: fix null pointer deref

Signed-off-by: Rosen Penev <[email protected]>
PowerDNS · Dec 11, 2024 · c3a20ca · c3a20ca
1 parent 5089e2c
commit c3a20ca
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
@@ -942,10 +942,12 @@ void PacketHandler::addNSEC(DNSPacket& /* p */, std::unique_ptr<DNSPacket>& r, c
   DLOG(g_log<<"addNSEC() mode="<<mode<<" auth="<<d_sd.qname<<" target="<<target<<" wildcard="<<wildcard<<endl);
 
   if (d_sd.db == nullptr) {
-    if(!B.getSOAUncached(d_sd.qname, d_sd)) {
-      DLOG(g_log<<"Could not get SOA for domain"<<endl);
-      return;
-    }
+    return;
+  }
+
+  if (!B.getSOAUncached(d_sd.qname, d_sd)) {
+    DLOG(g_log << "Could not get SOA for domain" << endl);
+    return;
   }
 
   DNSName before,after;