Skip to content

Commit

Permalink
dnsdist: Fix shadowed variables
Browse files Browse the repository at this point in the history
  • Loading branch information
rgacogne committed Jul 5, 2024
1 parent ca43d04 commit bb25145
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pdns/dnsdistdist/dnsdist-discovery.cc
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ bool ServiceDiscovery::tryToUpgradeBackend(const UpgradeableBackend& backend)

/* remove the existing backend if needed */
if (!backend.keepAfterUpgrade) {
dnsdist::configuration::updateRuntimeConfiguration([&backend](dnsdist::configuration::RuntimeConfiguration& config) {
auto& backends = config.d_backends;
dnsdist::configuration::updateRuntimeConfiguration([&backend](dnsdist::configuration::RuntimeConfiguration& runtimeConfig) {
auto& backends = runtimeConfig.d_backends;
for (auto backendIt = backends.begin(); backendIt != backends.end(); ++backendIt) {
if (*backendIt == backend.d_ds) {
backends.erase(backendIt);
Expand Down
4 changes: 2 additions & 2 deletions pdns/dnsdistdist/dnsdist.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3436,8 +3436,8 @@ int main(int argc, char** argv)
auto ret = std::make_shared<DownstreamState>(std::move(config), nullptr, true);
addServerToPool("", ret);
ret->start();
dnsdist::configuration::updateRuntimeConfiguration([&ret](dnsdist::configuration::RuntimeConfiguration& config) {
config.d_backends.push_back(std::move(ret));
dnsdist::configuration::updateRuntimeConfiguration([&ret](dnsdist::configuration::RuntimeConfiguration& runtimeConfig) {
runtimeConfig.d_backends.push_back(std::move(ret));
});
}
}
Expand Down

0 comments on commit bb25145

Please sign in to comment.