Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Quotes on Search #1215

Closed

Conversation

racerguy
Copy link
Contributor

⚡ PowerGrid - Pull Request

Welcome and thank you for your interest in contributing to our project!. You must use this template to submit a Pull Request or it will not be accepted.


Motivation

  • [x ] Bug fix
  • [x ] Enhancement?
  • New feature
  • Breaking change

Description

Ignores double and single quotes on search.

Related Issue(s): #_____.

Documentation

This PR requires Documentation update?

  • Yes
  • [x ] No
  • I have already submitted a Documentation pull request.

@luanfreitasdev
Copy link
Collaborator

Hi!, thanks for the contribution. However, at this point I think it makes more sense to use the beforeSearch method.

https://livewire-powergrid.com/table/add-columns.html#before-search

@racerguy
Copy link
Contributor Author

Hi!, thanks for the contribution. However, at this point I think it makes more sense to use the beforeSearch method.

https://livewire-powergrid.com/table/add-columns.html#before-search

BeforeSearch only seems to modify value from the search input. However to remove quotes it also needs to be on the database table and field.

Would it be better if I create a separate function or boolean for this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants