Implement "SHOW COLUMNS" rewrite #122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs some tests for the suite to validate |
mattbucci
requested changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks for contributing, please see https://github.com/PostgreSQL-For-Wordpress/postgresql-for-wordpress?tab=readme-ov-file#contributing
"If you find a failing scenario please add a test for it, A PR which fixes a scenario but does not include a test will not be accepted."
|
Hi, I did add some more changes, but they are on another branch. It might make more sense to merge that into here, although I would continue to use my fork in my containers for being faster to fix if something is broken, which would mean multiple PRs from the same branch to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
SHOW COLUMNS, currently onlySHOW FULL COLUMNSis implementedAdded Tests: