(Draft) Trying to fix BIGINT issues - #116
Closed
0xFEEDC0DE64 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Most of these regexes are already case insensitive. I think we can just add an "i" to the end of This should make this case insensitive and either bigint variation should match |
mattbucci
requested changes
Apr 10, 2024
mattbucci
left a comment
Collaborator
There was a problem hiding this comment.
Make regexes match insensitively
Collaborator
|
Looks like we have a failing test, but it's the test itself that is incorrect. |
Author
|
Have you found another solution for this problem? |
Collaborator
|
See #131 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we should not only cover BIGINT and not only in CREATE TABLE statements...
but this is for now what fixes my problem with wp-statistics