fix(outro): only promise the setup report when it exists on disk#811
Draft
posthog[bot] wants to merge 1 commit into
Draft
fix(outro): only promise the setup report when it exists on disk#811posthog[bot] wants to merge 1 commit into
posthog[bot] wants to merge 1 commit into
Conversation
The wizard's outro (exit line, outro screen) and the coding-agent handoff prompt all reference `posthog-setup-report.md` whenever `reportFile` is set, but the report is only ever written by the agent as an optional, soft step. On runs where the agent never finishes, no skill is installed, or the model skips the "write a report" instruction, the file is never created — yet the terminal still confidently tells the user to open a file that isn't there, and the handoff prompt tells their coding agent to read the same missing file. Gate the promise on reality: before the linear runner publishes its outro, strip `reportFile` and `handoffPrompt` when the file isn't on disk (the orchestrator runner already does the equivalent existsSync check). Also surface the resolved absolute path instead of a bare `./` so users who pass `--install-dir` know where to actually look. Generated-By: PostHog Code Task-Id: 8a6643cb-d3fd-4994-885b-4c156b8fe11c
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users finishing the wizard are told to open
./posthog-setup-report.md, but that file is often never written — the report is only ever produced by the agent as an optional, soft step. On runs where the agent doesn't finish, no skill is installed, or the model skips the "write a report" instruction, the outro still confidently points at a file that doesn't exist, and the coding-agent handoff prompt tells the user's agent to read that same missing file. This is the very last thing users see, so the broken promise erodes trust right at the finish line and has generated support tickets.Changes
reportFileandhandoffPromptare stripped when the file isn't on disk (extracted into a smallgateReportOnDiskhelper). The orchestrator runner already did the equivalentexistsSynccheck — the linear path just didn't../in the exit line and outro screen, so users who pass--install-dirknow where to actually look. Already-absolute paths (the orchestrator's queue-file fallback) are left untouched.Test plan
gateReportOnDisk(strips/keeps report + handoff based on disk state).pnpm build && pnpm test(1207 passing) andpnpm lint(0 errors).LLM context
Authored by Claude via PostHog Code from an inbox report. Fix targets
exit-line.ts,OutroScreen.tsx, and the linear runner's outro publish step.Created with PostHog Code from an inbox report.