-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce playwright e2e tests #28178
Open
pauldambra
wants to merge
11
commits into
chore/measure-backend-on-depot
Choose a base branch
from
chore/plywrt-1
base: chore/measure-backend-on-depot
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+773
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
changed the title
chore: measure backend on depot
chore: introduce playwright e2e tests
Feb 1, 2025
pauldambra
changed the base branch from
master
to
chore/measure-backend-on-depot
February 1, 2025 14:13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR introduces comprehensive E2E testing infrastructure changes, migrating from Cypress to Playwright and moving backend CI to Depot runners for improved performance measurement.
- Switches CI backend jobs to use
depot-ubuntu-latest
runners in.github/workflows/ci-backend.yml
for performance measurement - Adds new Playwright E2E testing framework with authentication setup, page objects, and test specs in
/playwright/
directory - Introduces race condition risk in
bin/e2e-test-runner
with duplicate code blocks and background process handling - Configures Playwright for CI environment with specific Chrome launch arguments and authentication state management in
playwright.config.ts
- Creates new CI workflow
.github/workflows/ci-e2e-playwright.yml
with container image caching and test execution on Depot
10 file(s) reviewed, 16 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very basic copy from #23248
let's get the smallest set running that we can
(accidentally stacked on top of #28177 🫠)