Devex/tailwindv4 color replacements attempt 4 #28175
Open
+4,254
−2,832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing, add scroll shadows to personsPreview
…ndary, --text-secondary
…d session recording mb-0
…th --border-primary
…ed survey preview being z-index 9999px by wrapping in .survey-view
…tory as it's the default
…default with --text-primary
…mmented out css vars
…o have bg- in front to match others, added z-index var for resizer
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements a comprehensive color system update across the PostHog frontend, migrating to Tailwind CSS v4 with semantic color tokens.
- Replaces legacy color variables (--bg-3000, --border, --muted) with semantic equivalents (--bg-primary, --border-primary, --text-secondary) in SCSS files
- Updates Tailwind configuration with new color system plugins including @csstools/postcss-gamut-mapping
- Migrates text color classes from text-muted/text-muted-alt to text-secondary for better semantic meaning
- Standardizes background colors using bg-surface-primary instead of bg-bg-light across components
- Removes utilities.scss in favor of Tailwind's built-in color utilities
458 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings | Greptile
| ignoreAtRules: ['theme', 'custom-variant'], | ||
| }, | ||
| ], | ||
| 'scss/at-rule-no-unknown': null, |
There was a problem hiding this comment.
style: Potential conflict with line 43-48 which also configures at-rule handling - consider consolidating these rules
Comment on lines
78
to
80
| &:hover { | ||
| background-color: var(--accent-3000); | ||
| background-color: var(--bg-surface-primary); | ||
| } |
There was a problem hiding this comment.
style: Counter step hover now uses --bg-surface-primary instead of --accent-3000, which may affect visual hierarchy
📸 UI snapshots have been updated165 snapshot changes in total. 0 added, 165 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?