Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): Add primary and secondary metric explanation #28160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielbachhuber
Copy link
Contributor

Changes

Adds an explanation of primary and secondary metrics to the new experiment UI

Before

CleanShot 2025-01-31 at 12 24 41@2x

After

CleanShot 2025-01-31 at 12 24 01@2x

How did you test this code?

Visual review

@danielbachhuber danielbachhuber requested a review from a team January 31, 2025 20:25
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the MetricsView component by adding clear explanations about primary and secondary metrics in experiments, improving user understanding.

  • Added informative tooltips in /frontend/src/scenes/experiments/MetricsView/MetricsView.tsx explaining primary metrics as main experiment goals and secondary metrics as additional context
  • Added empty state explanations for both metric types with improved text formatting and max-width constraints
  • Implemented hover tooltips that appear when metrics are present to provide ongoing context
  • Enhanced visual layout with proper spacing and text balance for better readability

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: +5 B (0%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +5 B (0%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant