feat: switch playback to our own rrweb #28148
Open
+355
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR switches from using the original rrweb packages to PostHog's own published versions, aiming to incorporate features from v13 through v18+/HEAD.
- Replaces
[email protected]and related packages with@posthog/[email protected]and its corresponding packages inpackage.json - Updates all imports from
@rrweb/*to@posthog/rrweb*across multiple files while maintaining existing type definitions - Enhances
rr-web-schema.jsonwith more detailed type definitions and node serialization support - Adds decompression logic and improved error handling in
sessionRecordingDataLogic.ts - Potential concern: Version downgrade from 2.0.0-alpha to 0.0.4 could introduce compatibility issues
24 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+445
to
+455
| "attributes": { | ||
| "additionalProperties": { | ||
| "type": ["string", "number", "boolean", "null"] | ||
| }, | ||
| "properties": { | ||
| "_cssText": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "type": "object" | ||
| }, |
There was a problem hiding this comment.
style: New attributes definition allows for CSS text but doesn't restrict other attribute types - could potentially allow invalid attribute values through
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're publishing
@posthog/rrweb*nowusing it in the player should be safe, and get us all the missing things between v13 and v18+/HEAD