fix: migration 0550 #28135
Open
fix: migration 0550 #28135
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes critical issues with Django model imports in migration files by ensuring proper usage of the apps registry for accessing historical model versions during migrations.
- Modified
/posthog/migrations/0550_migrate_action_webhooks_to_destinations.pyto correctly passappsparameter to migration function - Updated
/posthog/management/commands/migrate_action_webhooks.pyto useapps.get_model()instead of direct model imports - Added
hog_function_initparameter inconvert_to_hog_function()for proper dependency injection - Test file
/posthog/management/commands/test/test_migrate_action_webhooks.pyneeds fixing as it's missingappsdefinition and still uses direct imports
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -58,7 +58,7 @@ def test_migrate_large_number_of_actions_across_teams(self): | |||
| ) | |||
|
|
|||
| # Run the migration | |||
| migrate_all_teams_action_webhooks() | |||
| migrate_all_teams_action_webhooks(apps) | |||
There was a problem hiding this comment.
logic: The 'apps' parameter is undefined. This will cause a NameError when running the test. The test needs to properly mock or obtain the apps registry.
Suggested change
| migrate_all_teams_action_webhooks(apps) | |
| from django.apps import apps | |
| migrate_all_teams_action_webhooks(apps) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Importing DJango models directly in a migration code cases problems (some fields do not exist)
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?