chore: merge project permissions into advanced permissions

[zlwaterfield]

Changes

Follow along on RBAC: #24512

Billing PR to be shipped after this: https://github.com/PostHog/billing/pull/1092

Deprecating project_based_permissioning and merging into advanced_permissions.

Currently advanced_permissions is used for dashboard permissions and project_based_permissioning is used for permissions around projects like private projects. With the new RBAC / access control system we are merging these together and they will be available on the teams add-on.

Since both of these are available on the same plans right now, this should have no affect to users. I confirmed that every plan that has advanced_permissions also has project_based_permissioning and vice versa.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

It doesn't have an impact.

How did you test this code?

[github-actions]

Size Change: -766 B (-0.07%)

Total Size: 1.16 MB

ℹ️ View Unchanged

Filename	Size	Change
frontend/dist/toolbar.js	1.16 MB	-766 B (-0.07%)

_{compressed-size-action}

[posthog-bot]

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

• chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[greptile-apps]

PR Summary

This PR consolidates project-based permissions into advanced permissions across the PostHog codebase. Here's a summary of the key changes:

• Removes PROJECT_BASED_PERMISSIONING feature flag and merges its functionality into ADVANCED_PERMISSIONS across all files
• Updates feature checks in access control components and logic to use ADVANCED_PERMISSIONS instead of PROJECT_BASED_PERMISSIONING
• Maintains existing functionality since both features were previously available on the same plans
• Aligns with new RBAC/access control system where permissions will be available through teams add-on
• Includes comprehensive test updates to verify permission system still works correctly after consolidation

Key points to review:

• TODO comment on line 115 in AccessControlObject.tsx about index mapping needs to be addressed
• Migration path for existing installations should be verified to ensure smooth transition
• Documentation and frontend code references to PROJECT_BASED_PERMISSIONING need to be updated
• Legacy test classes that are commented out should be reviewed for proper migration to new system

_{16 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}