update start session recording instructions #9460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marandaneto
approved these changes
Sep 27, 2024
ivanagas
reviewed
Sep 27, 2024
contents/docs/libraries/js/index.mdx
Outdated
Comment on lines
383
to
388
| // if you use ingestion controls they still apply, | ||
| // you can pass override config to make sure the session starts | ||
| // even if your ingestion controls would not have allowed it | ||
| // so you could be sampling only 80% of sessions that match a particular linked flag | ||
| // and still start recording for the current session using | ||
| posthog.startSessionRecording({ linked_flag: true, sampling: true }) |
There was a problem hiding this comment.
- Instead of a paragraph of comments, we can just do a paragraph.
- It still is a bit confusing from this what the overrides do.
I'll take a crack at fixing this, think we need to adjust some of the surrounding information anyways.
ivanagas
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this twitter thread https://x.com/pauldambra/status/1839600015137808631 we realised the docs aren't too helpful if you're running session replay with linked flags or sampling but want to start a recording manually
so, let's update them