simplify example in Next.js A/B tests tutorial #9457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaksenko is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
When reading the tutorial, I got a weird feeling with one of the examples. An effect without dependencies and without async function is probably useless. Then I realized that it is most probably to allow `PHProvider` to call `posthog.init` before `posthog.getFeatureFlag` is called. I think this reason shouldn't be implicit, and two ways to make it clear are (afaik): 1. Add a comment explaining the reason. 2. Use the feature flags component (`PostHogFeature` from `posthog-js/react`). I think you want the tutorial to be as minimal as possible (using the component only adds more cognitive load), therefore I opted for the comment.
senky
force-pushed
the
simplify-nextjs-example
branch
from
3da58da
to
0da9600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When reading the tutorial, I got a weird feeling with one of the examples. An effect without dependencies and without async function is probably useless. Then I realized that it is most probably to allow
PHProviderto callposthog.initbeforeposthog.getFeatureFlagis called.I think this reason shouldn't be implicit, and two ways to make it clear are (afaik):
PostHogFeaturefromposthog-js/react).I think you want the tutorial to be as minimal as possible (using the component only adds more cognitive load), therefore I opted for the comment.