This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Add a badge to show the substitution count #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also will add mouseovers with the original text.
We already ignore the immediate children of script, form, etc. elements, as well as spans that we've inserted ourselves. This change makes us skip the entire subtree of such an element. One important effect is that if another extension changes one of our spans using a similar algorithm to ours (inserting a new subtree) we previously could end up reprocessing that node in a future document_end event. Now, we prevent that.
This also changes the disabled icon, since it has a drawn-in badge. If it makes substitutions but then disables the extension, then the substitution count is still shown until the page is reloaded (because there are still substitutions on the page). The two badges conflict visually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note that this pull request is based on top of #48. The code to count substitutions is different depending on whether or not #48 is accepted, so I wrote this branch assuming it would be. That means that #48's diffs show up here too; I'll update the pull request once #48 is accepted or rejected.)
Add a badge to show the substitution count.
This also changes the disabled icon, since it has a drawn-in badge. If it makes substitutions but then the user disables the extension, the substitution count is still shown until the page is reloaded (because
there are still substitutions on the page). The two badges conflict visually, so this pull request changes the disabled icon.