-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change CMake library name back to portaudio
from PortAudio
#963
Conversation
I looked at the PR and it seems limited to changing the case of "PortAudio" to "portaudio". But the CMake build for Ubuntu and MacOS is failing with: /home/runner/work/portaudio/portaudio/qa/loopback/src/paqa.c:45:10: fatal error: portaudio.h: No such file or directory For MInGW: Cannot specify link libraries for target "PortAudio" which is not built by |
Thanks for the PR. It's failing CI, I'm not sure why, could you take a look please? It seems like there are still some active occurrences of |
baefe5b
to
babbc2e
Compare
@RossBencina @philburk Could You retry, please? I merged yet another commits. I fixed cases in tests, examples and CMakeLists.txt. On my CI is now running successful. |
portaudio
from PortAudio
@dechamps @dmitrykos other CMake users: Please could you weigh in on this. Right now I see no reason to break V19.7 users by renaming the library but maybe I'm missing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change can be considered as a bug fix for an earlier breaking change.
Lacking any objections from CMake experts, I think we should do this.
I would have liked to hear some feedback from CMake users, but there has been none for over a month. Without further information this PR effectively fixes a regression relative to V19.7. If there was a valid reason to rename the library to camel case I don't what it is, and without that information I have no way to evaluate the benefit of not merging this PR. So we're going to go ahead and merge it. |
Fixes #939 .
EDIT (added by RossBencina):
The purpose of this patch is to revert back to the CMake library name
portaudio
(all lowercase) that is used in our current V19.7 release. This avoids breaking things for all users of V19.7 CMake support. Note that this is not agit revert
but rather a manual renaming.