wasapi: Fix wrong sign in timeInfo.inputBufferAdcTime calculation. #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADC capture time must be earlier than currentTime, as the capture time of any received samples in a buffer must be in the past. Fix the wrong sign in calculation to fix this. Signed-off-by: Mario Kleiner <[email protected]>
philburk
approved these changes
Oct 13, 2023
RossBencina
approved these changes
Oct 13, 2023
|
@kleinerm thanks! @dmitrykos Phil and I think this looks good, if you're ok with it would you like to go ahead and merge it please. |
|
@RossBencina, sorry noticed this thread only now and the fix looks correct. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADC capture time must be earlier than currentTime, as the capture time of any received samples in a buffer must be in the past.
Fix the wrong sign in calculation to fix this.