-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New header design #6
Conversation
I was doing something weird, and then decided not to, so this can go back to being normal;
Screenshot plaz |
Looks hot. Might want a "responsive table" layout of some kind, but I really dig the new header. |
PR's accepted , but. yeah, We've done that in other tables. By we I mean @graygilmore. It's a good idea. |
Really slick change, I like! |
@@ -12,13 +11,13 @@ select { | |||
a { | |||
&:link, | |||
&:visited { | |||
color: $green; | |||
color: $blue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me trés sad. No $color-link
and $color-link-hover
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
très
Nobody uses old or middle French anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But ping pong tables are green! |
%nav.main-navigation{ class: [write_access? && "has-write-access"] } | ||
.main-header-wrap | ||
%header.main-header | ||
%h1.site-title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should only be the h1
on the home page and be a div
everywhere else.
Our table is blue. You haven't been gone that long! |
Hahaha |
Yeah, looks better in the blue I agree. |
No description provided.