Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New header design #6

Merged
merged 14 commits into from
Feb 23, 2016
Merged

New header design #6

merged 14 commits into from
Feb 23, 2016

Conversation

jarednorman
Copy link
Contributor

No description provided.

@Sinetheta
Copy link
Member

Screenshot plaz

@jarednorman
Copy link
Contributor Author

whateverkevin

@Sinetheta
Copy link
Member

Looks hot. Might want a "responsive table" layout of some kind, but I really dig the new header.

@jarednorman
Copy link
Contributor Author

PR's accepted :trollface:, but. yeah, We've done that in other tables. By we I mean @graygilmore. It's a good idea.

@graygilmore
Copy link
Contributor

The green of the navigation is a little in-your-face. What about something like:

screen shot 2016-02-22 at 11 06 16 pm

@graygilmore
Copy link
Contributor

Really slick change, I like!

@@ -12,13 +11,13 @@ select {
a {
&:link,
&:visited {
color: $green;
color: $blue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me trés sad. No $color-link and $color-link-hover?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

très

Nobody uses old or middle French anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11

@jarednorman
Copy link
Contributor Author

But ping pong tables are green!

%nav.main-navigation{ class: [write_access? && "has-write-access"] }
.main-header-wrap
%header.main-header
%h1.site-title
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should only be the h1 on the home page and be a div everywhere else.

@graygilmore
Copy link
Contributor

But ping pong tables are green!

Our table is blue. You haven't been gone that long!

@jarednorman
Copy link
Contributor Author

Hahaha

@jarednorman
Copy link
Contributor Author

Yeah, looks better in the blue I agree.

adammathys added a commit that referenced this pull request Feb 23, 2016
@adammathys adammathys merged commit d870732 into PorkChopClub:master Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants