Extract GroupSummarySection to scope shimmer to labels - #773
Merged
Merged
Conversation
- Limit running shimmer to the category label instead of the full count - Unregister shimmer when the section becomes inactive - Add component tests and retarget MCP plural locale references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupSummarySection(withSummaryLabel) fromToolCallGroupfor collapsed group summary rows: icon, animated count, localized label, and optional diff stats.useShimmer, keeping the count static and settingdata-poracode-shimmer-textto the label alone (e.g.command, not1 command).GroupSummarySection.test.tsxand updateToolCallGroup.test.tsxto cover shimmer targeting and inactive teardown.