Merge pull request #527 from PolymerElements/selection-keydown

Check selectionEnabled before _selectionHandler on keydown
PolymerElements · May 25, 2018 · 856f2b1 · 856f2b1
2 parents e31a151 + ffb30a8
commit 856f2b1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/iron-list.html b/iron-list.html
@@ -1876,7 +1876,7 @@
           break;
         case /* ENTER */ 13:
           this._focusPhysicalItem(this._focusedVirtualIndex);
-          this._selectionHandler(e);
+          if (this.selectionEnabled) this._selectionHandler(e);
           break;
       }
     },

diff --git a/test/selection.html b/test/selection.html
@@ -187,6 +187,11 @@
         MockInteractions.tap(list._physicalItems[1]);
 
         assert.equal(list.selectedItems.length, 0);
+
+        list._physicalItems[1].focus();
+        MockInteractions.keyDownOn(list._physicalItems[1], 13 /* ENTER */);
+
+        assert.equal(list.selectedItems.length, 0);
       });
 
     test('toggle', function() {