Resolve bare specifiers PRIOR to compilation. #3405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
were you able to confirm this fixes the transform issue? I believe I tried this first initially and the issue is that it doesn't process the plugins in the same order. It seems like |
|
@btopro OH the nature of the problem comes from the fact that our babel-plugin-dynamic-import-amd.ts is doing a path.traverse in its own Program visitor 🤦♂️ I'm going to try and fix that right now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue about specifiers NOT being transformed when the AMD transform is involved as reported in #3402 #3403
This PR is a possible alternative to #3404, inferring from that work that the ordering of babel transform plugins was at issue. This simply moves specifier resolution to the beginning of the js-transform sequence.