This repository has been archived by the owner on May 29, 2019. It is now read-only.
3.0-ify start/first-element/* #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 859a2e4.
ghost
assigned 
ghost
requested review from
keanulee
suggested changes
Apr 26, 2018
app/3.0/start/first-element/intro.md
Outdated
| yarn install | ||
|
|
||
| ``` | ||
| yarn install |
There was a problem hiding this comment.
We don't use yarn anymore - use npm install and package-lock.json instead
|
@arthurevans ready for you to look at |
keanulee
approved these changes
Apr 30, 2018
|
|
I noticed one style thing I think we should do differently, but nothing that should block merging. I opened that as #2552. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staged here: https://3-0-first-element-dot-polymer-project.appspot.com/3.0/start/first-element/intro
Uses https://github.com/PolymerLabs/polymer-3-first-element
fixes #2538