New endpoint: price history #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xBoringWozniak
changed the title
0xBoringWozniak
changed the title
|
@poly-rodr plz take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request includes changes to add functionality for retrieving price history in the
py_clob_clientpackage. The most important changes include adding new methods to theClobClientclass, updating the endpoints, and creating an example script to demonstrate the new functionality.Issue #89
Description
New functionality for retrieving price history:
py_clob_client/client.py: Addedget_price_history_with_intervalandget_price_history_with_timestampsmethods to theClobClientclass to retrieve price history using different parameters.Endpoint updates:
py_clob_client/endpoints.py: Added a new endpointGET_PRICE_HISTORYfor price history retrieval.Example script:
examples/get_price_history.py: Created a new example script to demonstrate how to use theget_price_history_with_intervalmethod of theClobClientclass.Types of changes
Status
[WIP]if necessary (changes not yet made).