Cleanup waypoints #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyvest
approved these changes
Jun 19, 2024
| @@ -278,22 +352,24 @@ public static void renderWayPoint(String str, Vector3f loc, float partialTicks) | |||
| GlStateManager.translate(x, y, z); | |||
| GlStateManager.translate(0, viewer.getEyeHeight(), 0); | |||
|
|
|||
| renderNametag(str); | |||
| OneColor color = new OneColor(-1); | |||
There was a problem hiding this comment.
put this onecolor instance somewhere else so that its not being created every frame this is being drawn
no issues in my testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just really old changes that I was planning on doing more but yeah stuff happened. It OneConfig'ifys NEU's waypoint utils and allows for more customization. Just PRing because I saw this branch still existed and might as well open a PR for it, will probably go through during summer break and clean up more stuff as well.
Related Issue(s)
N/A
How to test
It should be identical visually. Most of it is still kinda of unused (there are few places in Hytils where we need these)
Release Notes
Documentation