Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPH new functions #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LolalyLuo
Copy link

Hi! I added pph_delete_account and pph_change_password! And here it is!
Please let me know if any other changes need to be made!

* PARAMETERS:
* pph_context *ctxt: This is the context in which the account will change password
*
* const unit8 *username: This is the desirerd user to be deleted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desired user whose password needs to be changed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@dhishan
Copy link
Contributor

dhishan commented Sep 1, 2016

pph_change_password 👍

Tests performed:

  • Reload and change [no secret] - doesn't change
  • Reload and unlock [has Secret] - changes successfully

pph_delete_account:

Tests Performed:

  • Reload and change [no secret] - deletes

    Shouldn't it have the secret to perform the deletion?

  • Reload and unlock [has Secret] - deletes

@SantiagoTorres
Copy link
Member

  • Reload and change [no secret] - deletes

Shouldn't it have the secret to perform the deletion?

I think the change is for a bootstrap account. Let me dig into this, it sounds correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants