Fix medicare_quarters_of_coverage invalid adds syntax #7260
+24
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `adds` attribute was incorrectly set to a parameter path that resolves to a scalar integer (40), when it should be a list of variable names. This caused `msp` calculations to fail with TypeError when the full calculation chain was exercised. Replaced the invalid `adds` with a proper formula that reads from the parameter. Added tests: - medicare_quarters_of_coverage.yaml: Unit test for default value - msp_benefit_value.yaml: Integration test exercising full calculation chain without mocking intermediate values Fixes PolicyEngine#7256 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7260 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 10 7 -3
=========================================
- Hits 10 7 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hua7450
approved these changes
Jan 27, 2026
Collaborator
|
Maybe we should apply Max's comment in issue @daphnehanse11 ? |
Per Max's review: - Removed default_quarters_of_coverage parameter (not a policy value) - Made medicare_quarters_of_coverage a pure input variable with no default - API users must explicitly provide medicare_quarters_of_coverage or is_premium_free_part_a - Updated integration test to provide explicit value Principle: Default assumptions about person characteristics don't belong in the model as parameters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
medicare_quarters_of_coveragevariable which used an invalidaddssyntax, causing MSP calculations to faildefault_quarters_of_coverageparameter file (not a policy value from law)medicare_quarters_of_coveragea pure input variable with no defaultmedicare_quarters_of_coverage: 40oris_premium_free_part_a: truePrinciple
Default assumptions about a person's characteristics don't belong in the model as parameters. Policy parameters should only reflect values from law.
Test plan
msp_benefit_value.yamltests pass (including integration test with explicitmedicare_quarters_of_coverage)base_part_a_premium.yamltests passFixes #7256
🤖 Generated with Claude Code