-
Notifications
You must be signed in to change notification settings - Fork 201
Update Arizona 2025 Individual Income Tax Model #7112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Arizona 2025 Individual Income Tax Model #7112
Conversation
Starting implementation of Arizona 2025 individual income tax updates. Documentation and parallel development will follow. Fixes PolicyEngine#7111 Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Update az_base_standard_deduction.yaml with 2025 values (Single: $15,000, Joint: $30,000, HOH: $22,500, Separate: $15,000) - Update az_increased_standard_deduction_for_charitable_contributions.yaml with 34% rate tests - Add az_529a_able_account_subtraction.yaml testing $2,000/$4,000 limits by filing status - Add az_adoption_expense_subtraction.yaml testing $40,000 cap (2025) and $5,000/$10,000 limits (2026+) - Add az_wood_stove_conversion_subtraction.yaml testing $500 cap - Add az_families_tax_rebate_subtraction.yaml for one-time rebate subtraction - Add az_income_tax_filing_required.yaml with 2025 filing thresholds - Add integration_2025.yaml for end-to-end 2025 Arizona tax calculation scenarios Tests based on 2025 Arizona Form 140 Instructions and A.R.S. 43-1022, 43-1027, 43-1041 Closes PolicyEngine#7111 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Update parameters with 2025 values: - Standard deduction: Single $15,000, Joint $30,000, HOH $22,500 - Increased standard deduction rate: 34% - Add 2025 references to all tax rate and subtraction files New subtractions implemented: - az_529a_able_account_subtraction: $2,000/$4,000 cap based on filing status - az_adoption_expense_subtraction: $40,000 for 2023-2025 (reverts to $5,000/$10,000 in 2026) - az_wood_stove_conversion_subtraction: $500 maximum - az_families_tax_rebate_subtraction: Pass-through for federal taxable rebate New filing requirement variable: - az_income_tax_filing_required: Thresholds $15,750 (single), $31,500 (joint) All values parameterized with zero hard-coded numeric values. References embedded from official Arizona DOR documentation. Fixes PolicyEngine#7111 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Tests created based on documentation for Arizona 2025 income tax model update.
Variables and parameters for Arizona 2025 income tax model update.
- Add 2025 standard deductions ($15,750 single/$31,500 joint/$23,625 HOH) - Update Arizona income tax parameters with 2025 references - Add comprehensive 2025 integration tests - Update charitable contribution, capital gains, family tax credit, dependent credit, and exemption parameters Closes PolicyEngine#7111 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 6 -4
Lines 144 69 -75
=========================================
- Hits 144 69 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Review: Arizona 2025 Income Tax Model UpdateOverall Assessment: APPROVE with minor suggestionsThis PR correctly implements Arizona 2025 income tax updates including standard deduction increases, charitable contribution rate updates, new subtractions, and filing requirement thresholds. The implementation is well-structured and properly wired into the existing Arizona tax model. What's Working Well
Should Address
# policyengine_us/variables/gov/states/az/tax/income/az_income_tax_filing_required.py:8
unit = USD # Should be removed - this is a bool variable
Suggestions (Non-blocking)
Validation Summary
Next Steps
Generated with Claude Code |
- Remove `unit = USD` from boolean variable az_income_tax_filing_required.py - Remove 6 duplicate filing requirement tests from integration_2025.yaml (already in dedicated test file) - Remove 3 redundant passthrough tests from az_families_tax_rebate_subtraction.yaml - Renumber integration test sections after removal 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Fixes AppliedIssues Fixed
Verification
Summary
Total test reduction: 9 duplicate/redundant tests removed Ready for re-review. |
PavelMakarchuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High level notes
policyengine_us/parameters/gov/states/az/tax/income/filing_requirement.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/az/tax/income/az_income_tax_filing_required.py
Outdated
Show resolved
Hide resolved
...e_us/variables/gov/states/az/tax/income/subtractions/az_wood_stove_conversion_subtraction.py
Outdated
Show resolved
Hide resolved
...ine_us/variables/gov/states/az/tax/income/subtractions/az_families_tax_rebate_subtraction.py
Show resolved
Hide resolved
...engine_us/variables/gov/states/az/tax/income/subtractions/az_adoption_expense_subtraction.py
Outdated
Show resolved
Hide resolved
…ction, make adoption expenses federal Per reviewer feedback: - Remove az_income_tax_filing_required variable and filing_requirement parameter - Remove az_wood_stove_conversion_subtraction (no relevant data) - Convert az_adoption_expenses to federal qualified_adoption_expenses input - Keep az_families_tax_rebate_subtraction (subtraction is needed for tax filings) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Review Feedback AddressedChanges Made
Details
Files ChangedDeleted:
Added:
Modified:
Verification
Question for ReviewerRegarding Arizona Families Tax Rebate: I kept the subtraction because it serves a legitimate purpose - users who received the 2023/2024 rebate need to subtract it from Arizona taxable income (federally taxable but AZ-exempt). Should this also be removed, or is the current approach acceptable? Ready for re-review. |
Reference Page Numbers for 2025 Arizona Form 140 InstructionsBased on review of the 2025 Arizona Form 140 Instructions PDF, here are the page numbers for each parameter file to add Standard Deductions
Exemptions
Tax Rates
Credits - Dependent Tax Credit
Credits - Family Tax Credit
Credits - Increased Excise Tax Credit
Credits - Property Tax
Subtractions
New Variables - Arizona Families Tax Rebate
Example Reference Formatreference:
- title: 2025 Arizona Form 140 Instructions, Line 36 Item D
href: https://azdor.gov/sites/default/files/document/FORMS_INDIVIDUAL_2025_140i.pdf#page=17Regulatory Verification SummaryAll parameter values in this PR have been verified against the official 2025 Arizona Form 140 Instructions:
|
Missing: 2025 Arizona Charitable Contribution Credit LimitsThe following 2025 parameter values should be added to complete the Arizona tax model update: Form 321 - Qualifying Charitable Organizations (QCO)File:
Form 352 - Qualifying Foster Care Charitable Organizations (QFCO)File:
Source |
Arizona Families Tax Rebate - Implementation NoteThe current implementation uses an input variable ( Rebate Formula
Caps:
Comparison with Other States
IL and RI use current-year data for simulation purposes (limited to 2021 via Sources |
PR #7112 - Remaining IssuesFiles to Remove
Variable Pattern Issues
Parameter Issues
Enhancement
|
Responds to Ziming's review comments: 1. Add page number anchors (#page=XX) to all 2025 Form 140 references - 30+ parameter files now link directly to relevant pages - Organized by section: deductions, exemptions, rates, credits, subtractions 2. Add 2025 QCO/QFCO charitable contribution limits - Form 321 (QCO): $987 joint / $495 other filing statuses - Form 352 (QFCO): $1,234 joint / $618 other filing statuses - Source: azdor.gov/tax-credits/credits-contributions-qcos-and-qfcos Note: Arizona Families Tax Rebate remains as input variable (not converted to calculated formula) since it's a one-time rebate based on 2021 data. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Fixes Applied (Ziming's Comments)Issues Fixed
Not Implemented (Design Decision)Arizona Families Tax Rebate - Kept as input variable rather than converting to calculated formula because:
Verification
Files Changed34 parameter files updated with page anchors and 2025 QCO/QFCO values. 🤖 Generated with Claude Code |
- Remove new variables from household/expense folder (az_able_account_contributions, qualified_adoption_expenses, az_families_tax_rebate_received) - Reuse federal able_contributions variable for ABLE subtraction - Create pre_subsidy_qualified_adoption_expenses in AZ folder - Add formula for rebate calculation based on dependents ($250 under 17, $100 17+) - Remove page numbers from reference titles in parameter files (keep page anchors in URLs) - Update tests to use correct variable names Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Addressed review feedback with the following changes: Variable refactoring:
Rebate formula:
Reference cleanup:
All 56 Arizona subtraction tests pass. |
|
We should add the tax rebate (I thought its a credit, but based on the variable naming, its a subtraction?) to one of the list, add it back to 2023? Or 2021? It should not be 2025 right? |
|
Need to fix this: Remove documentation field, use reference with URL in az_families_tax_rebate_subtraction.py |
Summary
Update the Arizona income tax model for tax year 2025, including parameter value updates, 2025 references for all parameters, and implementation of new modelable programs.
Fixes #7111
Changes
Parameter Value Updates
2025 Reference Updates
New Programs (Planned)
Status
Test Plan
make formatpassesmake testpassesPrimary Source
2025 Arizona Form 140 Instructions
This is a draft PR created for early visibility. Implementation work is in progress.