- 
                Notifications
    You must be signed in to change notification settings 
- Fork 201
Add the Georgia itemizer tax credit #6722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff            @@
##            master     #6722   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           22        13    -9     
=========================================
- Hits            22        13    -9     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
        
          
                policyengine_us/parameters/gov/states/ga/tax/income/credits/itemizer/amount.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                policyengine_us/parameters/gov/states/ga/tax/income/credits/itemizer/amount.yaml
          
            Show resolved
            Hide resolved
        
              
          
                policyengine_us/tests/policy/baseline/gov/states/ga/tax/income/credits/ga_itemizer_credit.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It says "per taxpayer" - sure it's just flat?
        
          
                policyengine_us/variables/gov/states/ga/tax/income/credits/ga_itemizer_credit.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                policyengine_us/variables/gov/states/ga/tax/income/credits/ga_itemizer_credit.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                policyengine_us/variables/gov/states/ga/tax/income/credits/ga_itemizer_credit.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                policyengine_us/variables/gov/states/ga/tax/income/credits/ga_itemizer_credit.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | defined_for = StateCode.GA | ||
|  | ||
| adds = ["gov.states.ga.tax.income.credits.itemizer"] | ||
| defined_for = "tax_unit_itemizes" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we'll need a GA filter in the formula - @PavelMakarchuk are you sure this is an improvement?
Fixes #6705