Upgrade to Python 3.13 #338
Conversation
There was a problem hiding this comment.
while here could we adopt the standard import numpy as np?
There was a problem hiding this comment.
great point! actually i did ran a sonaqube code analysis scanning which also pointed that, we could have a discussion about those issues all together for improvement https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=noman404_policyengine-core
There was a problem hiding this comment.
like there are several class methods do not have self also another standard practice
| @@ -0,0 +1,6 @@ | |||
| - bump: major | |||
There was a problem hiding this comment.
is this backwards-incompatible?
changelog_entry.yaml
Outdated
| changed: | ||
| - python 3.13.0 | ||
| - numpy 2.1.0 | ||
| date: 2025-01-30 02:47:17 |
There was a problem hiding this comment.
| date: 2025-01-30 02:47:17 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 84.73% 84.49% -0.24%
==========================================
Files 191 193 +2
Lines 9773 9920 +147
Branches 1018 1035 +17
==========================================
+ Hits 8281 8382 +101
- Misses 1204 1247 +43
- Partials 288 291 +3 ☔ View full report in Codecov by Sentry. |
|
That did strike me as strange in that part of the codebase, but I believe that’s actually by design, the idea being to obscure that part of the codebase away while building variables and other objects that proliferate throughout the tax code.
… On Jan 31, 2025, at 12:54 AM, Al Noman ***@***.***> wrote:
@noman404 commented on this pull request.
On policyengine_core/taxscales/marginal_rate_tax_scale.py <#338 (comment)>:
like there are several class methods do not have self also another standard practice
—
Reply to this email directly, view it on GitHub <#338 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSK7WZZQ4VKFNSB55ZL3632NK3TDAVCNFSM6AAAAABWDRRYYSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBVGM2TCMRRGQ>.
You are receiving this because you are subscribed to this thread.
|
Fixes #334