Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for get_policy_json function from the policy_service file #2222

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HerveRI
Copy link
Collaborator

@HerveRI HerveRI commented Feb 27, 2025

Added tests for get_policy_json function from the policy_service file. I also made changes to policy_service file as needed and added the fixtures file as well.

@HerveRI HerveRI requested a review from anth-volk February 27, 2025 16:21
@HerveRI HerveRI self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.58%. Comparing base (69fb911) to head (cec452d).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
tests/fixtures/policy_fixtures.py 80.00% 3 Missing ⚠️
policyengine_api/services/policy_service.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
- Coverage   75.59%   75.58%   -0.02%     
==========================================
  Files          79       83       +4     
  Lines        2934     3174     +240     
  Branches      311      350      +39     
==========================================
+ Hits         2218     2399     +181     
- Misses        651      706      +55     
- Partials       65       69       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant