Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK Parliamentary constituency estimates #2195

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

nikhilwoodruff
Copy link
Collaborator

Fixes #2191

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nikhilwoodruff, thanks for all of this. TL;DR:

  1. I believe Northern Irish and Welsh runs would crash with these changes
  2. I've flagged a few places I think typing and/or Pydantic schematization/dataclasses would be beneficial
  3. I think we should really discuss codifying "primary," "secondary," and "tertiary" country-level entities throughout the system, as I think this code illustrates the limits of the single-tier "region" designation

@anth-volk
Copy link
Collaborator

Per discussions with Nikhil, we'll be handling the sub-national entity standardization question in a separate issue down the road, which I'll be opening as an issue in -core.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 31.16883% with 53 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (b201ce4) to head (6056330).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
policyengine_api/endpoints/economy/compare.py 32.55% 29 Missing ⚠️
...ngine_api/jobs/calculate_economy_simulation_job.py 14.28% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2195      +/-   ##
==========================================
- Coverage   75.48%   74.49%   -0.99%     
==========================================
  Files          78       78              
  Lines        2921     2992      +71     
  Branches      309      322      +13     
==========================================
+ Hits         2205     2229      +24     
- Misses        651      698      +47     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikhilwoodruff! I'll move onto the corresponding front-end PR now. Just had a question meant to double-check something, as well as a couple minor comments.

@nikhilwoodruff nikhilwoodruff merged commit 1566f89 into master Feb 21, 2025
4 of 6 checks passed
@nikhilwoodruff nikhilwoodruff deleted the nikhilwoodruff/issue2191 branch February 21, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UK parliamentary constituencies
2 participants