Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove policy search test, add conftest #2147

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

anth-volk
Copy link
Collaborator

Fixes #2146

This PR removes a test that fails 30-40% of the time purely due to race conditions introduced by its improper emission of data directly to the database that we embed locally into the API when deploying. This removes that and adds explicit recognition of the test directory's path within a new conftest.py file.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (61742fb) to head (aa51ee8).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2147      +/-   ##
==========================================
- Coverage   77.83%   77.07%   -0.77%     
==========================================
  Files          67       68       +1     
  Lines        2775     2757      -18     
  Branches      292      289       -3     
==========================================
- Hits         2160     2125      -35     
- Misses        553      571      +18     
+ Partials       62       61       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anth-volk anth-volk merged commit f831e03 into master Feb 4, 2025
5 of 6 checks passed
@anth-volk anth-volk deleted the chore/disable-policy-test branch February 4, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable policy creation test that improperly commits to database
1 participant